Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the image-level meta data in WorkUnit #739

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

jeremykubica
Copy link
Contributor

As a step toward adding more provenance data in the workflow (specifically traveling through the WorkUnit), I regrouped a bunch of the data about constituent images into a single astropy Table. I think this makes it a little easier to track and reason about, but I could also make a case that this adds unneeded complexity. So let me know if you think this is worth it.

@DinoBektesevic
Copy link
Member

Hah, funny, sorry to double dip but I believe these two PRs might be related: #738

If we're already collating into BinTables from Headers - de-duplicating things like time stamps, per-image WCS et. al. via imagecollection HDU could be helpful here.

@jeremykubica
Copy link
Contributor Author

Hah, funny, sorry to double dip but I believe these two PRs might be related: #738

If we're already collating into BinTables from Headers - de-duplicating things like time stamps, per-image WCS et. al. via imagecollection HDU could be helpful here.

I agree that there is more cleanup we can do, especially with de-duplicating things. I was didn't want to make any changes to the serialized data in this PR though, since I don't want to introduce any incompatibilities with WorkUnits currently living on disk. I think we can do that in a future round.

I would need to talk through how to use the imagecollection HDU correctly.

Copy link
Collaborator

@maxwest-uw maxwest-uw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner!

@jeremykubica jeremykubica merged commit d9d4828 into main Nov 11, 2024
2 checks passed
@jeremykubica jeremykubica deleted the provenance branch November 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants